Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write to xml document #9299

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 6, 2024

Pull Request Description

This adds the ability to write a XML document back out to a file.

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley force-pushed the wip/adr/add-write-to-xml-document branch from 9c375b1 to be36db3 Compare March 6, 2024 13:13
@AdRiley AdRiley marked this pull request as ready for review March 6, 2024 13:17
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly stylistic but hate Boolean. :)

@AdRiley AdRiley merged commit 3ebf134 into develop Mar 6, 2024
26 of 28 checks passed
@AdRiley AdRiley deleted the wip/adr/add-write-to-xml-document branch March 6, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants