-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use autoscoping when constructing tag values of suggestion arguments #9293
Use autoscoping when constructing tag values of suggestion arguments #9293
Conversation
...-integration-tests/src/test/scala/org/enso/compiler/test/context/SuggestionBuilderTest.scala
Show resolved
Hide resolved
I had to update the enso/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso Lines 1009 to 1011 in 4971907
.. syntax after the #9452 is merged
autoscope_cons_demo.mp4 |
| B | ||
| C | ||
| | ||
|foo (a : T | K) = a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for T | Any->Any
or T | Function
. They may require a specific attention as described here.
How did you have to update the |
Method --- a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Index_Sub_Range.enso
+++ b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Index_Sub_Range.enso
@@ -80,12 +80,12 @@ type Index_Sub_Range
`Range` too.
default_options : Vector Option
default_options =
- o1 = Option "First" "(Index_Sub_Range.First 1)"
- o2 = Option "Last" "(Index_Sub_Range.Last 1)"
- o3 = Option "While" "(Index_Sub_Range.While (x-> False))"
- o4 = Option "By_Index" "(Index_Sub_Range.By_Index [0])"
- o5 = Option "Sample" "(Index_Sub_Range.Sample 10)"
- o6 = Option "Every" "(Index_Sub_Range.Every 2)"
+ o1 = Option "First" "(..First 1)"
+ o2 = Option "Last" "(..Last 1)"
+ o3 = Option "While" "(..While (x-> False))"
+ o4 = Option "By_Index" "(..By_Index [0])"
+ o5 = Option "Sample" "(..Sample 10)"
+ o6 = Option "Every" "(..Every 2)"
o7 = Option "Range" "(Range.new 0 100)"
[o1, o2, o3, o4, o5, o6, o7] And ascribe the argument of course --- a/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
+++ b/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
@@ -1008,7 +1008,7 @@ Text.repeat self count=1 =
"Hello World!".take (Sample 3 seed=42) == "l d"
@range Text_Sub_Range.default_widget
Text.take : (Text_Sub_Range | Index_Sub_Range | Range | Integer) -> Text ! Index_Out_Of_Bounds
-Text.take self range=(Index_Sub_Range.First 1) =
+Text.take self range:(Text_Sub_Range | Index_Sub_Range | Range | Integer)=(Index_Sub_Range.First 1) =
ranges = Codepoint_Ranges.resolve self range
case ranges of
Range.Between start end 1 -> |
Pull Request Description
close #9259
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.