-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pan to CB #9273
Pan to CB #9273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please add an e2e test (or extend existing "different ways of opening CB") to check if we pan when opening CB near corner. Or a case where we select a node, pan scene so the node is not visible, and press enter, and see if we eventually see CB (we'd probably need to suppress "autoscrolling page" in the check).
Pull Request Description
When the CB is opened, pan to show it.
Large screen:
Screen.Recording.2024-03-04.at.14.30.54.mov
Small screen:
Screen.Recording.2024-03-04.at.14.24.23.1.mov
Important Notes
A prioritized-coordinates approach is used to adjust panning goals based on screen space:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.