Some minor improvements suggested from Ned's use #9249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing imports.
Add default widgets to Data method.
jdunkerley
force-pushed
the
wip/jd/download-fixes
branch
from
a1b1b0e to
dafdf2d
Compare
jdunkerley
requested review from
radeusgd,
GregoryTravis and
AdRiley
as code owners
GregoryTravis
approved these changes
Mar 4, 2024
radeusgd
reviewed
Mar 4, 2024
| new : Text -> AWS_Credential | Nothing -> S3_File ! Illegal_Argument | ||
| new (uri : Text = S3.uri_prefix) (credentials : AWS_Credential | Nothing = Nothing) = | ||
| new : Text -> AWS_Credential -> S3_File ! Illegal_Argument | ||
| new (uri : Text = S3.uri_prefix) credentials:AWS_Credential=AWS_Credential.Default = |
There was a problem hiding this comment.
Suggested change
| new (uri : Text = S3.uri_prefix) credentials:AWS_Credential=AWS_Credential.Default = | |
| new (uri : Text = S3.uri_prefix) (credentials : AWS_Credential = AWS_Credential.Default) = |
nit: IMHO the version with spaces + parentheses is more readable
There was a problem hiding this comment.
will do as part of the ICON apply this evening.
radeusgd
reviewed
Mar 4, 2024
| - if_missing: The value to use if the selector isn't present. | ||
| @selector Widget_Helpers.make_column_name_selector | ||
| @index (t-> Widget.Numeric_Input minimum=0 maximum=t.row_count-1) | ||
| get_value : Text | Integer -> Integer -> Any -> Any |
There was a problem hiding this comment.
Why was get_value chosen over get_cell?
There was a problem hiding this comment.
bounced back and forth with Ned and we felt value was better but it was pretty equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
AWS_Credentialto have aDefaultand removed support forNothingfrom functions.Response_Body.to_filetoResponse_Body.write.writetoResponse.Table.get_valueandDB_Table.get_valueallowing getting a single value from a table.Data.downloadallowing downloading from a URL to a file.Datamethods.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.