Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection tests #9240

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix selection tests #9240

merged 1 commit into from
Mar 1, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

Sometimes our test realizes, that currentTarget of MouseEvent is a read-only property. I have no idea why it does not do it every time, but this fix should work.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [ ] The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • [ ] Unit tests have been written where possible.
    • [ ] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. -ci -gui labels Mar 1, 2024
@farmaazon farmaazon self-assigned this Mar 1, 2024
@farmaazon farmaazon marked this pull request as ready for review March 1, 2024 15:30
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Mar 1, 2024
@mergify mergify bot merged commit 55f3820 into develop Mar 1, 2024
29 of 30 checks passed
@mergify mergify bot deleted the wip/farmaazon/fix-selection-test branch March 1, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-ci -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants