-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align XML_Document and XML_Element APIs more. #9233
Conversation
Widget on Table.from_rows.
Changelog. Java format.
* @throws TransformerException | ||
* @throws ClassNotFoundException if the DOM implementation class cannot be found. | ||
* @throws IllegalAccessException if the DOM implementation class cannot be accessed. | ||
* @throws InstantiationException if the DOM implementation class cannot be instantiated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a hard time understanding what is the difference between being able to access the class from instantiate it.
Do we need the distinction? Couldn't we throw the same kind of exception for these cases?
Is this exception even expected at all? Isn't it some kind of internal error if it occurs?
Pull Request Description
to_table
extensions on some core types.Any.to
.Column.info
,Table.info
,DB_Column.info
andDB_Table.info
.Table.cross_tab
andDB_Table.cross_tab
.name
,get
,at
,inner_xml
andouter_xml
toXML_Document
.get
andat
onXML_Document
andXML_Element
. (Some bug in annotation code with Dmitry)get
andat
to not allow XPath and just get direct child/attribute values.get_xpath
toXML_Document
.get_elements_by_tag_name
toget_descendants_by_tag_name
and added newget_children_by_tag_name
.child_names
andattribute_names
toXML_Document
andXML_Element
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.