Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing reading Data Links #9215

Merged
merged 50 commits into from
Mar 1, 2024
Merged

Implementing reading Data Links #9215

merged 50 commits into from
Mar 1, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd self-assigned this Feb 28, 2024
@radeusgd radeusgd changed the title Wip/radeusgd/9123 first data links Implementing reading Data Links Feb 28, 2024
radeusgd
radeusgd commented Feb 28, 2024
View reviewed changes
app/ide-desktop/lib/dashboard/src/data/dataLinkSchema.json
Comment on lines -95 to +97
"pattern": "^s3://[\\w.~-]+/[/\\w.~-]+$"
"pattern": "^s3://[a-z0-9.-]{3,63}/.{1,1024}$"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The S3 bucket name can only contain lowercase letters, digits, . and -. It has to be at least 3 characters long and at most 63 characters long.

There are a few more restrictions - e.g. it cannot start with -, it cannot contain double -- etc. But I thought that just checking the simple ones is enough - it's just a basic sanity check - even if the bucket name is valid, the bucket could not exist / be not accessible anyway, so this does not need to be comprehensive.

The bucket key can be arbitrary, but it has a limit of 1024 bytes, so the length limit is a heuristic of that.

@radeusgd radeusgd linked an issue Feb 28, 2024 that may be closed by this pull request
Initial implementation of Data Links #9123
Closed
7 tasks
somebody1234
somebody1234 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving CODEOWNERS and changes to the data file in the dashboard codebase.

@somebody1234
Copy link
Contributor

@radeusgd should the test file not also be owned by the libraries team?

Base automatically changed from wip/sb/use-validator-library to develop February 29, 2024 10:36
@radeusgd radeusgd force-pushed the wip/radeusgd/9123-first-data-links branch from 3a3c924 to 8db4f8a Compare February 29, 2024 11:43
@radeusgd
Copy link
Member Author

radeusgd commented Feb 29, 2024 •
edited
Loading

@radeusgd should the test file not also be owned by the libraries team?

@somebody1234 I was not sure, since it's written in TypeScript I thought it may make sense for changes to be approved by someone from GUI. But I guess it could be either way.

jdunkerley
jdunkerley approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a great place to build on top of.

distribution/lib/Standard/AWS/0.0.0-dev/src/S3/S3_Data_Link.enso Outdated Show resolved Hide resolved
@jdunkerley
Copy link
Member

@radeusgd should the test file not also be owned by the libraries team?

@somebody1234 I was not sure, since it's written in TypeScript I thought it may make sense for changes to be approved by someone from GUI. But I guess it could be either way.

I agree lets add it to libs to be able to approve too.

@radeusgd radeusgd changed the base branch from develop to wip/radeusgd/9202-fix-interop-string-case-of February 29, 2024 14:08
@radeusgd radeusgd force-pushed the wip/radeusgd/9123-first-data-links branch from 8db4f8a to f93d2e1 Compare February 29, 2024 14:45
radeusgd
radeusgd commented Feb 29, 2024
View reviewed changes
test/AWS_Tests/src/S3_Spec.enso
Comment on lines +552 to +553
#group_builder.specify "should be able to read a data link with custom credentials and secrets" pending=cloud_setup.pending <| cloud_setup.with_prepared_environment <|
group_builder.specify "should be able to read a data link with custom credentials and secrets" pending="TODO: reading secrets from path" <| cloud_setup.with_prepared_environment <|
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is enabled in the next PR.

Base automatically changed from wip/radeusgd/9202-fix-interop-string-case-of to develop February 29, 2024 15:07
@radeusgd radeusgd force-pushed the wip/radeusgd/9123-first-data-links branch from 637a2cc to 81f9e40 Compare February 29, 2024 15:25
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Feb 29, 2024
@radeusgd radeusgd added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Mar 1, 2024
@mergify mergify bot merged commit 4316709 into develop Mar 1, 2024
26 of 28 checks passed
@mergify mergify bot deleted the wip/radeusgd/9123-first-data-links branch March 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@somebody1234 somebody1234 somebody1234 approved these changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@4e6 4e6 Awaiting requested review from 4e6

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp

@Akirathan Akirathan Awaiting requested review from Akirathan

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@wdanilo wdanilo Awaiting requested review from wdanilo wdanilo is a code owner

Assignees

@radeusgd radeusgd

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial implementation of Data Links
4 participants
@radeusgd @somebody1234 @jdunkerley @GregoryTravis