-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close dropdowns #9206
Close dropdowns #9206
Conversation
…cked, or Esc is pressed.
@@ -634,7 +582,7 @@ function handleEdgeDrop(source: AstId, position: Vec2) { | |||
:style="groupColors" | |||
v-on.="graphNavigator.events" | |||
v-on..="nodeSelection.events" | |||
@click="handleClick" | |||
@pointerdown="handleClick" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? I deliberately changed it to click once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was preventing some user actions triggering multiple handlers, but we can do that some other way. Fixing it isn't needed for this PR and it doesn't currently cause any observed problems.
Pull Request Description
Fixes #7562. Close a dropdown when:
Esc
is pressedInteraction
is started (i.e. using a shortcut)Important Notes
Interaction
API and uses it for closing/canceling CB as well as dropdowns.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.