Dropdown widget improvements. #9186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
added
CI: No changelog needed
MichaelMauderer
requested review from
Frizi,
farmaazon,
vitvakatu and
kazcw
as code owners
farmaazon
requested changes
Feb 29, 2024
There was a problem hiding this comment.
The arrow is wrongly moved to WidgetArgumentName; first, the task description says, that it should be under constructor name, not argument name; that is, centered under AggregateColumn.Group_By, not under AggregateColumn.Group_By 'some_name'
And the WidgetArgumentName is not always displayed; The arguments of nested calls, or list elements now have no arrow, I guess.
Comment on lines
40
to
42
| function identToLabel(name: IdentifierOrOperatorIdentifier): string { | ||
| return name.replaceAll('_', ' ') | ||
| return name | ||
| } |
There was a problem hiding this comment.
I think this function may be removed.
MichaelMauderer
force-pushed
the
wip/MichaelMauderer/Dropdown-Widget-Improvements
branch
from
6a8c63b to
9d21d79
Compare
|
Updated without the arrow changes after discussion with @farmaazon. They will be implemented in another task due to the unexpected complexity of the required implementation. |
farmaazon
approved these changes
Mar 4, 2024
…vements # Conflicts: # app/gui2/src/components/GraphEditor/widgets/WidgetSelection.vue
MichaelMauderer
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #8995
Peek.2024-03-01.16-06.webm
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.