Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Enso_Cloud from Data to top-level in Standard.Base #9140

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

  • 4 weeks ago we discussed with @jdunkerley we may want to move this module.
  • Data is a submodule mostly for various data-structures etc., the cloud stuff did not fit that well in there.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 22, 2024
@radeusgd radeusgd self-assigned this Feb 22, 2024
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Feb 22, 2024
@mergify mergify bot merged commit d817df9 into develop Feb 22, 2024
28 of 30 checks passed
@mergify mergify bot deleted the wip/radeusgd/move-cloud-module branch February 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants