Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload native-image argfiles #9094

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 19, 2024

Pull Request Description

In PR #8953, in commit ba0a69d, I have introduced argument files to the native-image. In this PR, let's try to upload these argfiles as artifacts on GH, so that we can inspect them later.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • Ensure that the native-image argfiles are uploaded as artifacts in the Engine CI action

@Akirathan
Copy link
Member Author

Blocked by #8953

@Akirathan Akirathan force-pushed the wip/akirathan/upload-ni-argfiles branch from 6dd43fe to bd24e29 Compare February 19, 2024 12:42
@Akirathan Akirathan self-assigned this Feb 19, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 19, 2024
build/build/src/engine/context.rs Outdated Show resolved Hide resolved
build/build/src/engine/context.rs Outdated Show resolved Hide resolved
build/build/paths.yaml Outdated Show resolved Hide resolved
@Akirathan Akirathan marked this pull request as ready for review February 22, 2024 11:16
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen a transient error in one of these tests in https://github.com/enso-org/enso/actions/runs/8008485751/job/21875023502?pr=9094#step:8:1214. I am adding more tests here to be sure that the transient either stops reoccurring, or we will have to deal with it by providing some flaky spec to JUnit. The problem is that I was not yet able to find a (simple) way how to mark a unit test in JUnit 4 as flaky.

@Akirathan
Copy link
Member Author

Akirathan commented Feb 23, 2024

All the artifacts are uploaded and can be downloaded from https://github.com/enso-org/enso/actions/runs/8008485751?pr=9094. The artifacts are:

  • Engine Runner native-image-args
  • Launcher native-image-args
  • Project Manager native-image-args

I have manually downloaded all the artifacts and checked their contents. As expected, all of them contain a single native-image-args.txt file with appropriate content. The only thing that is surprising for me is that the Rust CI tool claims that the upload of Project Manager native-image-args failed (in https://github.com/enso-org/enso/actions/runs/8008485751/job/21875023502?pr=9094#step:8:17080) and yet, it is correctly uploaded. Any ideas why that is the case @mwu-tow ?

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan Akirathan added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 26, 2024
@Akirathan Akirathan added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Feb 26, 2024
@mergify mergify bot merged commit f48caac into develop Feb 26, 2024
28 of 30 checks passed
@mergify mergify bot deleted the wip/akirathan/upload-ni-argfiles branch February 26, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants