Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard delete of items in Trash #9091

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Hard delete of items in Trash #9091

merged 7 commits into from
Mar 6, 2024

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Feb 19, 2024

Pull Request Description

Important Notes

None

Screenshots

"Clear Trash" button (only when in Trash category):
image
"Delete Forever" context menu option:
image
"Delete All Forever" context menu option:
image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard labels Feb 19, 2024
@somebody1234
Copy link
Contributor Author

done basic testing, seems to work with the new backend fixes.

@somebody1234
Copy link
Contributor Author

(both individual delete and "clear trash" - which makes sense because both use the same endpoint.)

Copy link
Contributor

@indiv0 indiv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, QA passed ✅

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Mar 6, 2024
@mergify mergify bot merged commit 618080b into develop Mar 6, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/sb/empty-trash branch March 6, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants