Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backend errors in toast notifications #9078

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

Adds the message returned by the backend to the toast notification, so that the user gets a more detailed error message.

Important Notes

  • Not sure what's the best way to properly test this, as for a lot of the backend endpoints there is no easy way to (even intentionally) trigger them from the frontend, because the frontend does a decent amount of validation as well.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-chore Type: chore g-dashboard labels Feb 16, 2024
@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Feb 26, 2024
@mergify mergify bot merged commit 4e8f066 into develop Feb 26, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/sb/use-backend-errors branch February 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-chore Type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants