Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_xml component #8979

Merged
merged 60 commits into from
Feb 7, 2024
Merged

Add to_xml component #8979

merged 60 commits into from
Feb 7, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Feb 6, 2024

Pull Request Description

Adds new to_xml component

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley force-pushed the wip/adr/add-xml-writer branch from b7d8adc to c002feb Compare February 6, 2024 14:49
@AdRiley AdRiley changed the title Wip/adr/add xml writer Add to_xml component Feb 6, 2024
@AdRiley AdRiley marked this pull request as ready for review February 6, 2024 16:53
@AdRiley AdRiley requested a review from jdunkerley February 7, 2024 12:38
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good now.

@AdRiley AdRiley force-pushed the wip/adr/add-xml-writer branch from 0bcc45b to 132a35b Compare February 7, 2024 20:03
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Feb 7, 2024
@mergify mergify bot merged commit e3f6ff1 into develop Feb 7, 2024
26 of 27 checks passed
@mergify mergify bot deleted the wip/adr/add-xml-writer branch February 7, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants