Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store whole IR.Module in .bindings cache #8924

Merged
merged 42 commits into from
Feb 9, 2024
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
6803429
Store whole IR.Module in .bindings cache
JaroslavTulach Feb 1, 2024
20416bf
Shield against NPE
JaroslavTulach Feb 1, 2024
3331219
Nicer formatting
JaroslavTulach Feb 1, 2024
8dfcac9
Using ByteBuffer instead of byte[] in caches
JaroslavTulach Feb 1, 2024
05858a6
Let Persistace.read accept ByteBuffer
JaroslavTulach Feb 1, 2024
7be0865
Reading the cache in as MappedByteBuffer
JaroslavTulach Feb 1, 2024
ba07db8
Clarity: Splitting Cache API and SPI into separate classes
JaroslavTulach Feb 2, 2024
6a10a20
Single throws ClassNotFoundException is enough
JaroslavTulach Feb 2, 2024
b7fd968
Replace writable Cache fields with methods in Spi
JaroslavTulach Feb 2, 2024
e570e37
Cache is a final class
JaroslavTulach Feb 2, 2024
667260c
No need for special Impl inner classes
JaroslavTulach Feb 2, 2024
22ac510
No need for Cache.Metadata interface
JaroslavTulach Feb 2, 2024
c40bc2f
Eliminate one need for SerializationManager.apply
JaroslavTulach Feb 2, 2024
09abdc0
Less calls to serializationManager.deserialize
JaroslavTulach Feb 2, 2024
300972d
Introducing SerializationPool to deal with threading of Serialization…
JaroslavTulach Feb 3, 2024
0f53896
Let SerializationPool use QualifiedName as key
JaroslavTulach Feb 3, 2024
bb1272d
Removing Thread.sleep from Serialization manager code
JaroslavTulach Feb 3, 2024
570cfcd
Moving implementation of serializeModule to TruffleCompilerContext
JaroslavTulach Feb 3, 2024
fdfa387
Moving serializeLibrary into TruffleCompilerContext
JaroslavTulach Feb 3, 2024
9efb654
Moving doSerializeModule into TruffleCompilerContext
JaroslavTulach Feb 3, 2024
3d3b453
deserializeModule moved to TruffleCompilerContext
JaroslavTulach Feb 3, 2024
a960069
Rewriting doSerializeLibrary & co. to Java
JaroslavTulach Feb 3, 2024
4b75e45
Removing remaining methods from SerializationManager.scala
JaroslavTulach Feb 3, 2024
f9982cf
Removing SerializationManager
JaroslavTulach Feb 3, 2024
47c28da
Adjusting tests to removed SerializationManager
JaroslavTulach Feb 4, 2024
d663e06
Use asSpi to extract cache implementation in tests
JaroslavTulach Feb 4, 2024
44471d2
Merging with DiagnosticFormatter
JaroslavTulach Feb 4, 2024
a471e6a
Only log when Standard library IR file is loaded
JaroslavTulach Feb 4, 2024
8b26678
Thread.join to ensure threads are gone
JaroslavTulach Feb 4, 2024
ba32efb
Thread.join all threads before closing the context
JaroslavTulach Feb 4, 2024
5a99f95
SuggestionsCache needs InputStream over buffer
JaroslavTulach Feb 4, 2024
58b5078
Compose the results
JaroslavTulach Feb 4, 2024
77b1369
Merge branch 'develop' into wip/jtulach/CachePerLibrary_8639
mergify[bot] Feb 4, 2024
1577744
Use underscore
JaroslavTulach Feb 6, 2024
c729c74
There is no library name anymore as deserializeSuggestions method cha…
JaroslavTulach Feb 6, 2024
947824e
When recovering from deserialization IOException, don't useCaches whe…
JaroslavTulach Feb 6, 2024
c061494
Only mmap files larget than 3MB - e.g. mostly .bindings files
JaroslavTulach Feb 7, 2024
bbd6d99
Don't generate .ir files when compiling a library. They are stored in…
JaroslavTulach Feb 7, 2024
76f47a7
Make sure the stacktrace isn't lost
JaroslavTulach Feb 7, 2024
11776a6
Compute suggestions first before (possibly) overriding .bindings file
JaroslavTulach Feb 7, 2024
5a4bfa9
Improving javadoc & co.
JaroslavTulach Feb 8, 2024
a2b2945
Avoid using caches when reparsing
JaroslavTulach Feb 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class ImportResolver(compiler: Compiler) {
u.compilationStage(CompilationStage.INITIAL)
}
)
compiler.ensureParsed(mod)
compiler.ensureParsed(mod, false)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use caches to avoid this NPE.

b = mod.getBindingsMap()
}

Expand Down
Loading