-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Tests
to Base_Tests
to be more descriptive
#8781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
requested review from
jdunkerley,
GregoryTravis,
AdRiley,
4e6,
JaroslavTulach,
hubertp,
Akirathan and
mwu-tow
as code owners
January 16, 2024 17:37
radeusgd
added
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
labels
Jan 16, 2024
Akirathan
approved these changes
Jan 16, 2024
jdunkerley
approved these changes
Jan 16, 2024
GregoryTravis
approved these changes
Jan 16, 2024
JaroslavTulach
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just today I was dreaming of moving the tests next to the sources of the module. E.g. distribution/lib/Standard/Base/0.0.0-dev/test/
directory and running them with enso --test distribution/lib/Standard/Base/0.0.0-dev/
command.
Renaming seems to cause no harm.
radeusgd
force-pushed
the
wip/radeusgd/rename-base-tests
branch
from
January 17, 2024 09:41
9ed3369
to
f9a90f8
Compare
mwu-tow
approved these changes
Jan 17, 2024
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
As [discussed on Discord](https://discord.com/channels/401396655599124480/1197160815040667779) the dry-run of benchmarks shall be performed only on Linux. This is meant to avoid CI issues that currently block #[8781](#8781).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Tests
which sounds very generic and sounds like it could contain really anything. Now this is 'fixed' by ensuring the name reflects the module being tested -Base
.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.