Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Tests to Base_Tests to be more descriptive #8781

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

  • All of our test projects contain the name of the module they are testing, except for Tests which sounds very generic and sounds like it could contain really anything. Now this is 'fixed' by ensuring the name reflects the module being tested - Base.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Jan 16, 2024
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just today I was dreaming of moving the tests next to the sources of the module. E.g. distribution/lib/Standard/Base/0.0.0-dev/test/ directory and running them with enso --test distribution/lib/Standard/Base/0.0.0-dev/ command.

Renaming seems to cause no harm.

@radeusgd radeusgd force-pushed the wip/radeusgd/rename-base-tests branch from 9ed3369 to f9a90f8 Compare January 17, 2024 09:41
@radeusgd radeusgd merged commit 71427c3 into develop Jan 17, 2024
29 checks passed
@radeusgd radeusgd deleted the wip/radeusgd/rename-base-tests branch January 17, 2024 15:19
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
As [discussed on Discord](https://discord.com/channels/401396655599124480/1197160815040667779) the dry-run of benchmarks shall be performed only on Linux.

This is meant to avoid CI issues that currently block #[8781](#8781).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants