Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary operator resolution based on that value #8779

Merged
merged 67 commits into from
Jan 27, 2024
Merged
Show file tree
Hide file tree
Changes from 62 commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
3c4112f
assert the returned value is Ordering or Nothing
JaroslavTulach Jan 16, 2024
7407518
Specs definition how Complex and Number shall interoperate
JaroslavTulach Jan 16, 2024
83d3ecb
Merge remote-tracking branch 'origin/develop' into wip/jtulach/BigDec…
JaroslavTulach Jan 17, 2024
80a28b8
verifyOperationWithConvertibleObject test
JaroslavTulach Jan 17, 2024
bc66409
AddNode passes the verifyOperationWithConvertibleObject test
JaroslavTulach Jan 17, 2024
3ad5e40
Pass VirtualFrame around
JaroslavTulach Jan 17, 2024
a96ed7d
Let all the Integer numeric binary operators delegate to Integer.doOther
JaroslavTulach Jan 17, 2024
8e7d36a
Handle node manipulations in interpreter mode
JaroslavTulach Jan 17, 2024
59d67a7
Ordering with conversions
JaroslavTulach Jan 17, 2024
7b53460
Wrap.Int self with Integer that
JaroslavTulach Jan 17, 2024
aeaf9ea
More ordering and equality tests
JaroslavTulach Jan 17, 2024
19a29f4
Making package private
JaroslavTulach Jan 17, 2024
855d5b6
Simplify by using InteropConversionCallNode
JaroslavTulach Jan 17, 2024
6fad8ef
Merge remote-tracking branch 'origin/develop' into wip/jtulach/BigDec…
JaroslavTulach Jan 17, 2024
4447663
Avoid wrapping internal exceptions by PolyglotException
JaroslavTulach Jan 18, 2024
5d89ef0
Testing UnresolvedConversion equality
JaroslavTulach Jan 18, 2024
56d0062
Module, ModuleScope are only equal when they are equal
JaroslavTulach Jan 18, 2024
ccc3d99
Introducing DoThatConversionNode
JaroslavTulach Jan 18, 2024
3bb1a75
Benchmark to measure DoThatConversionNode performance of AddNode
JaroslavTulach Jan 18, 2024
6dd00d0
Unit test to verify operator conversions
JaroslavTulach Jan 22, 2024
4e73593
Introducing MethodRootNode.buildOperator
JaroslavTulach Jan 23, 2024
ffa2ab6
Do 'that conversion' for any binary operator
JaroslavTulach Jan 23, 2024
7e8f3b3
Avoiding need for special doThatConversion node for Integer
JaroslavTulach Jan 23, 2024
fd40ad0
Defining number builtins in separate private module
JaroslavTulach Jan 23, 2024
a9cbfaa
Moving all Integer builtins into Number_Builtins
JaroslavTulach Jan 23, 2024
390aaf8
Float uses Number_Builtins
JaroslavTulach Jan 23, 2024
b6f2f57
TypeError in compare signals Incomparable_Values
JaroslavTulach Jan 23, 2024
46b7f81
Some ordering operations now yield a Type_Error
JaroslavTulach Jan 23, 2024
ab93dd2
Catch the Type_Error Panic and return False
JaroslavTulach Jan 23, 2024
e88366d
Overriding comparator operators forces conversion of Number to Complex
JaroslavTulach Jan 23, 2024
f1478eb
Static invocations exactly defines the function to run
JaroslavTulach Jan 23, 2024
5a7463e
Moving Number_Builtins into Internal package
JaroslavTulach Jan 24, 2024
f6a22e9
Allow Metadata to provide a prelude with imports
JaroslavTulach Jan 24, 2024
5e49801
Adjusting tests to imports and Number_Builtins
JaroslavTulach Jan 24, 2024
5a92888
assertInCode to verify two line based Positions
JaroslavTulach Jan 24, 2024
2b5feea
Down to 6 failures in RuntimeServerTest
JaroslavTulach Jan 24, 2024
26e2d76
Down to three failures
JaroslavTulach Jan 24, 2024
f65efd3
All RuntimeServerTests are passing
JaroslavTulach Jan 24, 2024
7e44e2d
Merge remote-tracking branch 'origin/develop' into wip/jtulach/BigDec…
JaroslavTulach Jan 24, 2024
52f37ee
Disabling TCK on numbers until + works again
JaroslavTulach Jan 25, 2024
8d5db65
Making SerdeCompilerTest pass again
JaroslavTulach Jan 25, 2024
5a6a468
Convert com.oracle.svm.core.jdk.UnsupportedFeatureError into ClassNot…
JaroslavTulach Jan 25, 2024
dff739e
Operators are no longer defined on numbers. Define own for now.
JaroslavTulach Jan 25, 2024
32428bb
Note in changelog
JaroslavTulach Jan 25, 2024
1da0a92
Adding missing imports into polyglot-api tests
JaroslavTulach Jan 25, 2024
138b885
Minimizing changes in number/integer package
JaroslavTulach Jan 25, 2024
bb4d4e9
No (static) builtin methods in Integer
JaroslavTulach Jan 25, 2024
6b9bdca
Equality with conversions isn't yet supported
JaroslavTulach Jan 25, 2024
85de834
Using multi-line vector 'literal'
JaroslavTulach Jan 25, 2024
06b7b5f
Reassignment now happens inside of Integer.+ invocation
JaroslavTulach Jan 25, 2024
439343f
Integer power Integer can (surprisingly) yield a non-integer!
JaroslavTulach Jan 25, 2024
48116c9
Testing EnsoMultiValue and conversions of operators
JaroslavTulach Jan 25, 2024
8f66cb5
Binary dispatch test with multivalue fixed by ReadaArgumentCheckNode …
JaroslavTulach Jan 25, 2024
efbe6a0
@Specialization handling EnsoMultiValue
JaroslavTulach Jan 25, 2024
0542f48
Apply the check even for null Type[]
JaroslavTulach Jan 26, 2024
4f23530
Verifying doThatConversionUncached handles many different types
JaroslavTulach Jan 26, 2024
1e9ef59
Faster bench.compileOnly=true
JaroslavTulach Jan 26, 2024
a131449
Import Numbers in the benchmarks
JaroslavTulach Jan 26, 2024
234417a
Documenting binary operator resolution based on that
JaroslavTulach Jan 26, 2024
080c977
Merge remote-tracking branch 'origin/develop' into wip/jtulach/BigDec…
JaroslavTulach Jan 26, 2024
25af881
javafmtAll
JaroslavTulach Jan 26, 2024
a93e6d6
Merging with develop branch
JaroslavTulach Jan 26, 2024
3dcf02a
Type first, default value then
JaroslavTulach Jan 26, 2024
ffe265b
Just return operatorNode
JaroslavTulach Jan 26, 2024
71e203b
Internal Javadoc update
JaroslavTulach Jan 26, 2024
c01085a
Formatting after applying suggestions
JaroslavTulach Jan 26, 2024
0e01b29
Don't swallow ArityException when -ea
JaroslavTulach Jan 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -1024,6 +1024,7 @@
- [Introduce Arrow language][8512]
- [DataflowError.withoutTrace doesn't store stacktrace][8608]
- [Derive --in-project from --run source location][8775]
- [Binary operator resolution based on that value][8779]

[3227]: https://github.com/enso-org/enso/pull/3227
[3248]: https://github.com/enso-org/enso/pull/3248
Expand Down Expand Up @@ -1178,6 +1179,7 @@
[8512]: https://github.com/enso-org/enso/pull/8512
[8608]: https://github.com/enso-org/enso/pull/8608
[8775]: https://github.com/enso-org/enso/pull/8775
[8779]: https://github.com/enso-org/enso/pull/8779

# Enso 2.0.0-alpha.18 (2021-10-12)

Expand Down
Loading
Loading