Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of GUI2 widgets fixes #8749

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Set of GUI2 widgets fixes #8749

merged 2 commits into from
Jan 15, 2024

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented Jan 12, 2024

Pull Request Description

Implements first two points of #8745

  1. The fix for drop-down was simple, just stop click propagation
  2. The fix for connections was much more complicated. It turned out, that it's about keeping track of hovered ports; when picking an option in WidgetSelection makes the drop-down disappear - but that won't emit pointerleave event, so the port was still deemed hovered. Changed the mechanism for tracking hovered port to more "centralized" one.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon self-assigned this Jan 12, 2024
@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug -gui labels Jan 12, 2024
@farmaazon farmaazon changed the title Set of GUI2 widget;s fixes Set of GUI2 widgets' fixes Jan 12, 2024
@farmaazon farmaazon changed the title Set of GUI2 widgets' fixes Set of GUI2 widgets fixes Jan 12, 2024
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Jan 15, 2024
@mergify mergify bot merged commit b28b743 into develop Jan 15, 2024
28 of 29 checks passed
@mergify mergify bot deleted the wip/farmaazon/fixes branch January 15, 2024 08:12
@farmaazon farmaazon mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants