Unable to access constructor value in interactive mode #8626
Conversation
4e6
added
the
CI: No changelog needed
|
Re-using the type in the compiler scope fixed the issue with method resolution. Now the fun part is to invalidate the scope (and the context caches) properly when the type is edited. |
| val logOut: ByteArrayOutputStream = new ByteArrayOutputStream() | ||
| val context = | ||
| Context | ||
| .newBuilder(LanguageInfo.ID) |
There was a problem hiding this comment.
It's probably not necessary and maybe even desirable for these tests, for you don't need to limit the polyglot Context to "enso". Now, in runtime, you have access to all the languages and instruments that we use everywhere.
…value-in-interactive-mode
|
I just realized that the update of cache invalidation logic will also fix the scenario when an import got changed making some of the symbols in the program invalid (unresolved). I remember that we have discussed this issue earlier but I was not able to find an open ticket for it. |
4e6
added
the
CI: Clean build required
…value-in-interactive-mode
| import java.util.UUID | ||
|
|
||
| @scala.annotation.nowarn("msg=multiarg infix syntax") | ||
| class RuntimeTypesTest |
There was a problem hiding this comment.
I'm not sure it is worth it but we already have runtime instrumentation tests in Java
| @@ -71,8 +71,9 @@ public ModuleScope( | |||
| this.exports = exports; | |||
| } | |||
|
|
|||
| public void registerType(Type type) { | |||
| types.put(type.getName(), type); | |||
| public Type registerType(Type type) { | |||
There was a problem hiding this comment.
What is the intended return value of this method? Is it:
- some
Type - previous
Type - newest
Type
I am not sure I get what the return type shall represent.
| @@ -396,7 +397,6 @@ public void reset() { | |||
| imports = new HashSet<>(); | |||
| exports = new HashSet<>(); | |||
| methods = new HashMap<>(); | |||
| types = new HashMap<>(); | |||
There was a problem hiding this comment.
ModuleScope.reset() no longer removes types. OK.
| @@ -406,7 +406,7 @@ public void modifyModuleSources( | |||
| rope -> { | |||
| logger.log( | |||
| Level.FINE, | |||
| "Applied edits. Source has {} lines, last line has {} characters", | |||
| "Applied edits. Source has {0} lines, last line has {1} characters.", | |||
There was a problem hiding this comment.
I see. Logging in Java requires {0}.
| @@ -345,6 +345,7 @@ public boolean isEigenType() { | |||
|
|
|||
| public void registerConstructor(AtomConstructor constructor) { | |||
| constructors.put(constructor.getName(), constructor); | |||
| gettersGenerated = false; | |||
There was a problem hiding this comment.
It would be nice, if this was covered by a (non Runtime*Test) unit test
There was a problem hiding this comment.
We shouldn't be adding new Scala code.
mergify
bot
deleted the
wip/db/7184-unable-to-access-constructor-value-in-interactive-mode
branch
Pull Request Description
close #7184
The constructor value was not accessible because during the re-compilation a new instance of the type was registered in runtime. Then during the execution, an old cached instance of the type was used in method resolution.
Changelog:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.