Preparing for AST-based synchronization #8625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Further AST integration and API refinement before introducing the new synchronization mechanism.
closes #8609
Important Notes
API changes:
Ast.parseExpression
/Ast.parse
to better reflect their usage:Ast.parse
returns a block or a single expression, depending on its input; this is convenient for expressions expected to be single-line.Ast.parseBlock
always treats its input as a block; this is suitable for parsing a file.astExtended
is no longer needed to access span information.Ast.span
provides access to the value when appropriate (the project's committed modules have spans; uncommitted changes or other parsed expressions don't).SourceRange
is now used everywhere in place ofContentRange
--the two types had the same definition.Features:
Implementation improvements:
imports
more thoroughly with new AST APIs.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.