Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for AST-based synchronization #8625

Merged
merged 13 commits into from
Jan 2, 2024
Merged

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Dec 22, 2023

Pull Request Description

Further AST integration and API refinement before introducing the new synchronization mechanism.

closes #8609

Important Notes

API changes:

  • Renamed Ast.parseExpression / Ast.parse to better reflect their usage:
    • Ast.parse returns a block or a single expression, depending on its input; this is convenient for expressions expected to be single-line.
    • Ast.parseBlock always treats its input as a block; this is suitable for parsing a file.
  • astExtended is no longer needed to access span information. Ast.span provides access to the value when appropriate (the project's committed modules have spans; uncommitted changes or other parsed expressions don't).
  • SourceRange is now used everywhere in place of ContentRange--the two types had the same definition.

Features:

  • Fix CodeEditor viewing.

Implementation improvements:

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw self-assigned this Dec 22, 2023
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 22, 2023
@kazcw kazcw marked this pull request as ready for review December 24, 2023 17:58
@Frizi Frizi self-requested a review January 2, 2024 15:05
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Jan 2, 2024
@mergify mergify bot merged commit 19d0707 into develop Jan 2, 2024
32 of 34 checks passed
@mergify mergify bot deleted the wip/kw/ast-sync-prep branch January 2, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AST-synchronization groundwork
2 participants