Report more errors to the user #8623
Conversation
MichaelMauderer
added
CI: No changelog needed
MichaelMauderer
force-pushed
the
wip/MichaelMauderer/gui2/Report-errors-to-the-user
branch
2 times, most recently
from
4b31b03 to
8d9c39d
Compare
MichaelMauderer
force-pushed
the
wip/MichaelMauderer/gui2/Report-errors-to-the-user
branch
2 times, most recently
from
e281c74 to
2fe3ffc
Compare
MichaelMauderer
force-pushed
the
wip/MichaelMauderer/gui2/Report-errors-to-the-user
branch
from
2fe3ffc to
15e206b
Compare
MichaelMauderer
requested review from
PabloBuchu,
indiv0 and
somebody1234
as code owners
| }) | ||
| } | ||
|
|
||
| function initiConnectionLostToast() { |
app/gui2/package.json
Outdated
| @@ -62,6 +62,7 @@ | |||
| "semver": "^7.5.4", | |||
| "sucrase": "^3.34.0", | |||
| "vue": "^3.3.4", | |||
| "vue-react-wrapper": "^0.3.1", | |||
There was a problem hiding this comment.
i think this should be a devDependency (npm i -D vue-react-wrapper) right? since it's only used during development (histoire)
| toastId: connectionLostToast, | ||
| }) | ||
| }, | ||
| { once: true }, |
There was a problem hiding this comment.
how did i not know about this option o_o
| }) | ||
| } | ||
|
|
||
| projectStore.lsRpcConnection.catch((err) => { |
There was a problem hiding this comment.
you can provide the catch callback as the second argument to the .then() below.
| @@ -32,6 +35,20 @@ main = | |||
| result = run_main benches | |||
| third_node = 2 + 2 | |||
| `) | |||
|
|
|||
| /// Note: These props should be synced with the props in | |||
There was a problem hiding this comment.
jsdocs are formatted like this:
/**
* docs here
*/otherwise just a double slash on the first line is fine
|
|
||
| /// Note: These props should be synced with the props in | ||
| // `app/ide-desktop/lib/dashboard/src/authentication/src/components/app.tsx`. | ||
| // We need this here, as the rect component is not part of the dashboard and not usually available in the demo scenes. |
| toastClassName: 'text-sm leading-170 bg-frame-selected rounded-2xl backdrop-blur-3xl', | ||
| limit: 3, | ||
| }) | ||
| const JSONView = createReactWrapper(ToastContainer, toastProps) |
There was a problem hiding this comment.
just want to confirm that name of JSONView is intentional?
There was a problem hiding this comment.
I don't think this is at all necessary. The react app already renders toast container, so issued toasts will already be linked to it automatically. We don't need to render additional container.
There was a problem hiding this comment.
Changed the name to something more sensible.
@Frizi This is our test environment. There is otherwise no react app running there, as we don't initialise the dashboard here, and thus no toast appears. Adding this, ensures the toast container is initialised in the demo scene and allows them to appear. Unless I am missing something?
…-the-user # Conflicts: # app/gui2/src/components/GraphEditor.vue
MichaelMauderer
deleted the
wip/MichaelMauderer/gui2/Report-errors-to-the-user
branch
Pull Request Description
Closes #8524 .
Screencast.from.21-12-23.14.52.20.webm
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.