Re-organize lib/dashboard/
#8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0 and
Frizi
as code owners
|
restructure finished! the new directory structure might not be perfect, but i think this is probably worth merging regardless? but anyway, given that it should be more or less complete, i'm now beginning to test using the |
somebody1234
added
the
CI: Clean build required
farmaazon
approved these changes
Dec 21, 2023
somebody1234
removed
the
CI: Clean build required
|
not sure why there was a merge error, automatic merged worked fine locally. |
somebody1234
added
the
CI: Clean build required
somebody1234
requested review from
MichaelMauderer,
vitvakatu and
kazcw
as code owners
PabloBuchu
approved these changes
Jan 9, 2024
|
Basic testing re-done on all cases after merge. |
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
This is required because `index.ts` was renamed to `entrypoint.ts` in order to avoid colliding with the main export of the `enso-dashboard` module, which is used by `gui2` as `dashboard.run()`. This file was renamed in #8587, causing the issue. Build script changes also included thanks to @mwu-tow. # Important Notes This should only affect projects opened against the remote (cloud) backend, meaning that to test this, you should open a project against the cloud backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
lib/dashboard/Important Notes
npm run devwhich (since quite recently) uses Vite.npm run devinapp/ide-desktop/lib/dashboard, ORnpm run dashboard:devinapp/ide-desktopnpm run build) which uses ESBuild.npm run dev)../run ide build./run ide watch./run ide2 build./run gui watchChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build.