Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Date_Diff widget #8561

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Fixes Date_Diff widget #8561

merged 2 commits into from
Dec 16, 2023

Conversation

radeusgd
Copy link
Member

Pull Request Description

The widget for Date_Diff was using wrong old name and thus did not work properly on one of the arguments.

Before it worked for second argument (end) but did not work for input:
image
image

Afterwards it works there too:
image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 15, 2023
@radeusgd radeusgd self-assigned this Dec 15, 2023
@radeusgd radeusgd added CI: Ready to merge This PR is eligible for automatic merge CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Dec 15, 2023
@mergify mergify bot merged commit 9428d12 into develop Dec 16, 2023
32 checks passed
@mergify mergify bot deleted the wip/radeusgd/fix-date-diff branch December 16, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants