Fix serialization of alias analysis graph #8550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
JaroslavTulach
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Change the ID as described in portability & versioning documentation. Otherwise OK - thanks for finding this omission of mine.
| @@ -168,6 +172,7 @@ protected Graph readObject(Input in) throws IOException { | |||
| protected void writeObject(Graph obj, Output out) throws IOException { | |||
| out.writeObject(obj.rootScope()); | |||
| out.writeInline(scala.collection.immutable.Set.class, obj.links()); | |||
| out.writeInt(obj.nextIdCounter()); | |||
There was a problem hiding this comment.
You have to change the id of the persisted object to signal that old caches can no longer be read.
JaroslavTulach
approved these changes
Dec 15, 2023
hubertp
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #8431
Fixes the scenario:
executionContext/executeExpressionIRis loaded from the cache (reading invalid alias analysis graph)EvalNodecompiles the expression to execute with the local scope containing an invalid aliasing graphAliasAnalysispass because of the clashing IDs in the graphImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.