Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc panel improvements #8530

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Doc panel improvements #8530

merged 7 commits into from
Dec 15, 2023

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Fixes parts of #8135

  • Fixed rendering of the documentation panel when no entry is selected.
  • Multiple improvements of tags in the documentation panel:
    • Group color for GROUP tag
    • Custom styling for DEPRECATED, UNSTABLE, and ADVANCED tags.
    • Sorting
    • Collapsing tags that exceed one line with a button
    • Filtering out some tags (ICON and TEXT_ONLY for now)
  • Filtering out private items from the documentation
  • Fixing group colors (was incorrectly assuming unique group names) and fallback color (was incorrectly replacing every character in the name with - before hashing, which was hilarious).
  • Fixing ComponentBrowser demo scene.
  • Minor fixes for mock database in demo scenes (removed duplicated entry, added an additional one for testing tags)
documentation.improvements.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Dec 13, 2023
@vitvakatu vitvakatu self-assigned this Dec 13, 2023
@vitvakatu vitvakatu requested a review from Frizi as a code owner December 13, 2023 09:58
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits (?)

app/gui2/src/components/DocumentationPanel.vue Outdated Show resolved Hide resolved
app/gui2/src/components/DocumentationPanel/DocsTags.vue Outdated Show resolved Hide resolved
app/gui2/src/components/DocumentationPanel/DocsTag.vue Outdated Show resolved Hide resolved
app/gui2/src/components/DocumentationPanel/DocsTag.vue Outdated Show resolved Hide resolved
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Dec 15, 2023
@mergify mergify bot merged commit 41cb4e3 into develop Dec 15, 2023
35 checks passed
@mergify mergify bot deleted the wip/vitvakatu/doc-panel-tags branch December 15, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants