Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new magnet axes #8506

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Add new magnet axes #8506

merged 5 commits into from
Dec 11, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

  • Closes Output type displays below other nodes #8460

    • Add new magnet axes 32px below the bottom of the previous node, and 32px above the top of the next node
  • Fix a bug where magnet alignment and "zoom to all" take into account nodes that no longer exist

  • Fix a bug where "zoom to all" breaks completely right after deleting a node

Important Notes

  • Snapping with bounded cross axes were discussed during refinement, but are out of scope of this PR.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug -gui labels Dec 11, 2023
@somebody1234 somebody1234 requested a review from Frizi as a code owner December 11, 2023 03:31
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Dec 11, 2023
@mergify mergify bot merged commit 0974d5f into develop Dec 11, 2023
34 checks passed
@mergify mergify bot deleted the wip/sb/add-new-magnet-axes branch December 11, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output type displays below other nodes
2 participants