Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Enso font #8499

Merged
merged 10 commits into from
Dec 8, 2023
Merged

Use Enso font #8499

merged 10 commits into from
Dec 8, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

Important Notes

None

Screenshots

Before:
image
image
After:
image
image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request -gui labels Dec 8, 2023
@somebody1234 somebody1234 requested a review from Frizi as a code owner December 8, 2023 11:04
@somebody1234 somebody1234 requested a review from kazcw December 8, 2023 11:05
@somebody1234
Copy link
Contributor Author

adding @kazcw as reviewer as he implemented the corresponding PR for GUI1.
(is there anywhere else that needs this font? most places should have it due to CSS cascading, but it may be conceptually clearer to explicitly add it in more places. alternatively, maybe it's currently being added in too many places - e.g. both main.css and App.vue)

app/gui2/stories/story.css Outdated Show resolved Hide resolved
@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Dec 8, 2023
Copy link
Contributor

@kazcw kazcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to watch out for is that the Enso Font is not intended to be used for non-code text without performing some glyph substitutions first (affecting period/space/hyphen): https://github.com/enso-org/font#using-enso-font-in-regular-sentences

Also, some visualizations will break if a non-monospaced font (like Enso Font) is used.

@somebody1234
Copy link
Contributor Author

hm... should we even be using Enso Font instead of M PLUS 1 in those cases then?

@somebody1234 somebody1234 removed the CI: Ready to merge This PR is eligible for automatic merge label Dec 8, 2023
@somebody1234
Copy link
Contributor Author

@kazcw also, which visualizations will break btw?

@kazcw
Copy link
Contributor

kazcw commented Dec 8, 2023

hm... should we even be using Enso Font instead of M PLUS 1 in those cases then?

Indeed--in GUI1 we were using three fonts:

  • Enso Font for code
  • M PLUS 1 for most non-code
  • Some monospace font (DejaVu Sans Mono?) for the text grid visualization (it looks like that isn't changed here)

It's a little inefficient since Enso Font and M PLUS 1 are mostly the same. Some day as an optimization (rather than glyph substitutions) we could reduce the Enso Font to only include a few glyphs, and specify the glyph fallbacks in CSS so that our code font is Enso Font overlayed on the base M PLUS 1 font.

@somebody1234
Copy link
Contributor Author

hmm... i think i'll switch back to M PLUS 1 for regular text, i can't imagine it being very performant to do text replacement on every single text span in Vue

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Dec 8, 2023
@enso-bot
Copy link

enso-bot bot commented Dec 8, 2023

E-Hern Lee reports a new STANDUP for yesterday (2023-12-08):

Progress: - implement

other issues -

  • (8228, PR 8501) partially refactor util folder
  • (8420, PR 8461) alternate implementation for bringing back missing edges It should be finished by 2023-12-12.

@mergify mergify bot merged commit 777ae9a into develop Dec 8, 2023
29 checks passed
@mergify mergify bot deleted the wip/sb/enso-font branch December 8, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Enso Font in new GUI
3 participants