-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Enso font #8499
Use Enso font #8499
Conversation
adding @kazcw as reviewer as he implemented the corresponding PR for GUI1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to watch out for is that the Enso Font is not intended to be used for non-code text without performing some glyph substitutions first (affecting period/space/hyphen): https://github.com/enso-org/font#using-enso-font-in-regular-sentences
Also, some visualizations will break if a non-monospaced font (like Enso Font) is used.
hm... should we even be using Enso Font instead of M PLUS 1 in those cases then? |
@kazcw also, which visualizations will break btw? |
Indeed--in GUI1 we were using three fonts:
It's a little inefficient since Enso Font and M PLUS 1 are mostly the same. Some day as an optimization (rather than glyph substitutions) we could reduce the Enso Font to only include a few glyphs, and specify the glyph fallbacks in CSS so that our code font is Enso Font overlayed on the base M PLUS 1 font. |
hmm... i think i'll switch back to M PLUS 1 for regular text, i can't imagine it being very performant to do text replacement on every single text span in Vue |
E-Hern Lee reports a new STANDUP for yesterday (2023-12-08): Progress: - implement other issues -
|
Pull Request Description
Important Notes
None
Screenshots
Before:
After:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible../run ide build
.