Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node output type #8488

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix node output type #8488

merged 1 commit into from
Dec 7, 2023

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug -gui labels Dec 7, 2023
@somebody1234 somebody1234 requested a review from Frizi as a code owner December 7, 2023 11:45
@somebody1234
Copy link
Contributor Author

i've done some basic testing and it seems to fix the issue. it may be a band-aid solution for now, not sure if there are better solutions

Copy link
Contributor

@Frizi Frizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do the trick for now. We will worry about the "proper solution" once the engine actually supports multiple outputs (if ever).

@mergify mergify bot merged commit f6cf827 into develop Dec 7, 2023
37 checks passed
@mergify mergify bot deleted the wip/sb/fix-node-output-type branch December 7, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No connections and wrong types under nodes
2 participants