Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for GUI2 #8478

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Small fixes for GUI2 #8478

merged 5 commits into from
Dec 6, 2023

Conversation

vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Dec 6, 2023

Pull Request Description

Includes the following fixes:

  1. Closes Adjust dropdown widget to match Figma design. #8472
    Adding animation when hovering entries, align them to the left, improve vertical alignment, make sure the currently selected entry is marked with rounded background shape.
fixed-dropdown.mp4
  1. Backspace is now used on MacOS for deleting nodes, instead of awkward combination Fn+Backspace.
  2. Fixed layout for vector editor.

Before:
Screenshot 2023-12-06 at 3 23 39 PM
After:
Screenshot 2023-12-06 at 6 21 56 PM

Also includes the fix for dynamic dropdowns from #8474. Closes #8473

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added the -gui label Dec 6, 2023
@vitvakatu vitvakatu self-assigned this Dec 6, 2023
@vitvakatu vitvakatu requested a review from Frizi as a code owner December 6, 2023 14:37
@vitvakatu vitvakatu mentioned this pull request Dec 6, 2023
5 tasks
@vitvakatu vitvakatu added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 6, 2023
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Dec 6, 2023
@mergify mergify bot merged commit 503d3d8 into develop Dec 6, 2023
34 of 37 checks passed
@mergify mergify bot deleted the wip/vitvakatu/small-fixes branch December 6, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic dropdowns broken with the latest engine Adjust dropdown widget to match Figma design.
2 participants