Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync presenter state not only on abort, but also on commit #8464

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Fixes #8336 (probably)

I couldn’t reproduce the issue after this change.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 5, 2023
@vitvakatu vitvakatu merged commit 3d63272 into develop Dec 7, 2023
33 of 34 checks passed
@vitvakatu vitvakatu deleted the wip/vitvakatu/sync-sync-sync branch December 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A node persists in erroneous state despite fixing the underlying problem
3 participants