Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix for editing problem #8456

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Quickfix for editing problem #8456

merged 4 commits into from
Dec 5, 2023

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented Dec 5, 2023

Pull Request Description

I can edit nodes after this fix. However, the cursor always lands at the end. - this is also fixed.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [ ] The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • [ ] Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon requested a review from Frizi as a code owner December 5, 2023 09:02
@farmaazon farmaazon added --bug Type: bug --regression Important: regression -gui labels Dec 5, 2023
@farmaazon farmaazon self-assigned this Dec 5, 2023
@farmaazon farmaazon added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 5, 2023
@farmaazon
Copy link
Contributor Author

Fixed the cursor position after editing start. Updated the description.

@farmaazon farmaazon linked an issue Dec 5, 2023 that may be closed by this pull request
2 tasks
@farmaazon farmaazon added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Dec 5, 2023
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Dec 5, 2023
@mergify mergify bot merged commit 6b837c3 into develop Dec 5, 2023
32 of 33 checks passed
@mergify mergify bot deleted the wip/farmaazon/fix branch December 5, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --regression Important: regression -gui CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing nodes by clicking on the does not work
3 participants