Cleanup after each test run #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: reducing leaks when running our test suite.
hubertp
force-pushed
the
wip/hubert/8408-macos-fails
branch
from
e53d95c to
2c78aec
Compare
hubertp
force-pushed
the
wip/hubert/8408-macos-fails
branch
from
2c78aec to
a04d09b
Compare
Shutdown hook keeps a reference to `RuntimeServerEmulator` which prevents things from being GC'ed.
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
hubertp
added
the
CI: No changelog needed
Akirathan
approved these changes
Nov 29, 2023
|
Running |
Eliminating shutdown hooks so that objects get GC'ed.
|
OK. Let's merge this as-is and I will have further improvements coming for |
JaroslavTulach
approved these changes
Nov 29, 2023
| context.executionContext.context.close() | ||
| context.runtimeServerEmulator.terminate() | ||
| if (context != null) { | ||
| context.reset() |
There was a problem hiding this comment.
This sequence seems to appear at many places. Shouldn't it be shared at a single place?
1 task
radeusgd
reviewed
Dec 4, 2023
| @@ -1,4 +1,6 @@ | |||
| package org.enso.distribution.locking | |||
|
|
|||
| /** A [[LockManager]] which guarantees to be thread-safe. */ | |||
| trait ThreadSafeLockManager extends LockManager | |||
| trait ThreadSafeLockManager extends LockManager { | |||
| def reset(): Unit | |||
There was a problem hiding this comment.
I think we should have a comment saying what is the purpose of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Reducing leaks when running our test suite.
Potentially fixes #8408.
Important Notes
Managed to keep thread count and memory in between runs relatively stable.
Initially:
Now:
The screenshot illustrates for
RuntimeVisualizationsTestonly. Will need to be applied in other places as well.Applying the same style to
runtime-with-instruments.Before:
After:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.