Enable profiling for all commands of runner executable #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
hubertp
approved these changes
Nov 8, 2023
| @@ -103,11 +103,11 @@ object ExecutorWithUnlimitedPool extends LanguageServerExecutor { | |||
| ) | |||
| val profilingPathArguments = | |||
| descriptor.profilingPath.toSeq | |||
| .flatMap(path => Seq("--server-profiling-path", path.toString)) | |||
There was a problem hiding this comment.
Weird. Even our docs mention --profiling-path and not --server-profiling-path
Akirathan
approved these changes
Nov 8, 2023
mergify
bot
deleted the
wip/db/8156-server-profiling-path-does-nothing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #8156
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.