-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable-private-check option #8202
Conversation
0b446df
to
dadae74
Compare
AmbiguousImportsAnalysis, | ||
PrivateModuleAnalysis.INSTANCE, | ||
AmbiguousImportsAnalysis | ||
) ++ (if (config.privateCheckEnabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, we only implement private modules via PrivateModuleAnalysis
compiler pass, there is no runtime checking yet. Thus, this conditional adding of PrivateModuleAnalysis
pass effectively disables the checks. In the future, when we will have more private stuff, like types, we will need some more sophisticated way to disable these checks. That is why the option is also in EnsoLanguage
and not only in CompilerConfig
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many changes just to pass a single flag... 🤦
I forgot to add the `--disable-private-check` cmdline option in #8202. This PR fixes this: ``` > enso -h | grep -A2 private --disable-private-check Disables private module checking at runtime. Useful for tests. ```
Fixes #8140. Follow-up of #7840.
Pull Request Description
Adds
--disable-private-check
option that essentialy disablesprivate
keyword.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.