Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reassigning of BindingsMap #8190

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Allow reassigning of BindingsMap #8190

merged 3 commits into from
Oct 31, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Oct 31, 2023 •
edited
Loading

Pull Request Description

Fixes #8186 by turning IllegalStateException into log message. Re-assigning of BindingsMap can happen in the IDE where evaluation of modules is repeated again and again. In addition to that avoid dropping errors in compiler without them being noticed.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 31, 2023
@JaroslavTulach JaroslavTulach self-assigned this Oct 31, 2023
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Oct 31, 2023
@mergify mergify bot merged commit f2cfd7f into develop Oct 31, 2023
29 checks passed
@mergify mergify bot deleted the wip/jtulach/AvoidISE_8186 branch October 31, 2023 10:03
@enso-bot enso-bot bot mentioned this pull request Nov 1, 2023
Closed
@hubertp hubertp mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactorings in BindingsMap lead to illegal state
3 participants
@JaroslavTulach @hubertp @Akirathan