Resolve imports and exports via cached BindingsMap #8160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
changed the title
|
The above picture represents the current state. The picture below shows the after applying this PR. The
|
JaroslavTulach
added
CI: Clean build required
Akirathan
approved these changes
Oct 27, 2023
engine/runtime/src/main/java/org/enso/interpreter/runtime/TruffleCompilerContext.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/TruffleCompilerContext.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/TruffleCompilerContext.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/compiler/phase/ImportResolver.scala
Show resolved
Hide resolved
hubertp
reviewed
Oct 27, 2023
engine/runtime/src/main/java/org/enso/interpreter/runtime/TruffleCompilerContext.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/compiler/SerializationManager.scala
Outdated
Show resolved
Hide resolved
| current, | ||
| { u => | ||
| u.bindingsMap(concreteBindings) | ||
| u.loadedFromCache(true) |
There was a problem hiding this comment.
Should we maybe have more than 2 states? It feels like 1) not yet loaded 2) loaded only bindings 3) full IR loaded would be more appropriate
There was a problem hiding this comment.
There is nobody reading the "three states" yet. Why shall we keep three states in memory when we only read two?
JaroslavTulach
removed
the
CI: Keep up to date
JaroslavTulach
deleted the
wip/jtulach/FastExportsAndImportsResolution_6100
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Addresses #6100 a bit.
org.enso.compiler.Compiler.runImportsAndExportsResolutionused to take up to three seconds as it triggered deserialization of megabytes ofIRcaches. Now it is faster as it uses library bindings cache. Alas, overall time isn't shortened, as further compiler passes still load (the same amount of)IRcaches in.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,