Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing CompilerContext.Module #8144

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Introducing CompilerContext.Module #8144

merged 9 commits into from
Oct 25, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Oct 24, 2023 •
edited
Loading

Pull Request Description

Avoids references to runtime.Module from Compiler & co.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Existing unit tests continue to pass.

@JaroslavTulach JaroslavTulach self-assigned this Oct 24, 2023
@JaroslavTulach JaroslavTulach marked this pull request as draft October 24, 2023 14:27
@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 24, 2023
@enso-bot enso-bot bot mentioned this pull request Oct 25, 2023
Closed
@JaroslavTulach JaroslavTulach marked this pull request as ready for review October 25, 2023 08:42
@JaroslavTulach
Copy link
Member Author

Tests seem to be green and I've fixed the formatting. Let's review the idea and integrate if it is acceptable.

hubertp
hubertp approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks to be addressed

engine/runtime/src/main/java/org/enso/interpreter/EnsoLanguage.java Outdated Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/compiler/context/CompilerContext.java Outdated Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/Module.java Outdated Show resolved Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/runtime/DefaultPackageRepository.scala Show resolved Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/runtime/DefaultPackageRepository.scala Show resolved Hide resolved
@JaroslavTulach JaroslavTulach merged commit 5e468f0 into develop Oct 25, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/CompilerModule_6100 branch October 25, 2023 15:11
@enso-bot enso-bot bot mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroslavTulach @hubertp