Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid null values in constant node #8061

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Avoid null values in constant node #8061

merged 2 commits into from
Oct 16, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Oct 16, 2023 •
edited
Loading

Pull Request Description

Prevents this NullPointerException by making sure ConstantNode rejects null during construction.

Important Notes

from Standard.Base import all
polyglot java import java.util.Random

main = 
    operator1 = Random.new

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 16, 2023
@JaroslavTulach JaroslavTulach self-assigned this Oct 16, 2023
@JaroslavTulach JaroslavTulach mentioned this pull request Oct 16, 2023
Merged
1 task
@JaroslavTulach @Akirathan
Proper error message
d3d5648 
Co-authored-by: Pavel Marek <[email protected]>
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Oct 16, 2023
@mergify mergify bot merged commit a85a576 into develop Oct 16, 2023
@mergify mergify bot deleted the wip/jtulach/AvoidNullInConstantNode branch October 16, 2023 15:50
@enso-bot enso-bot bot mentioned this pull request Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 4e6 approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaroslavTulach @4e6 @Akirathan