Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table.expand_to_rows to allow flattening vector and array values in table #8042

Merged
merged 47 commits into from
Oct 13, 2023
Merged

Add Table.expand_to_rows to allow flattening vector and array values in table #8042

merged 47 commits into from
Oct 13, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Oct 12, 2023 •
edited
Loading

Pull Request Description

Important Notes

Also includes a fix for a reallocation bug in InferredBuilder.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

GregoryTravis and others added 30 commits October 6, 2023 14:58
@GregoryTravis
one test
76c4f01
@GregoryTravis
single values
6cc1ee0
@GregoryTravis
singles with field lists
c02c06d
@GregoryTravis
json
b0498f4
@GregoryTravis
e+m
97fa5c2
@GregoryTravis
json
7b7d886
@GregoryTravis
array
bd13286
@GregoryTravis
expand_column
248f7b3
@GregoryTravis
prefix
f77eb4d
@GregoryTravis
error on db
e9afa39
@GregoryTravis
Merge branch 'develop' into wip/gmt/7958-from-objects-tests
c8a2825
@GregoryTravis
db tests pass
efe7926
@GregoryTravis
cleanup
b288c88
@GregoryTravis
group name
d26dd19
@GregoryTravis
tests
66a0c1a
@GregoryTravis
mixed
199ab21
@GregoryTravis
wrote
e02d44a
@GregoryTravis
works with inferred builder
5911986
@GregoryTravis
review
10d48eb
@GregoryTravis @radeusgd
Update test/Table_Tests/src/Common_Table_Operations/Conversion_Spec.enso
aedb4ad 
Co-authored-by: Radosław Waśko <[email protected]>
@GregoryTravis @radeusgd
Update test/Table_Tests/src/In_Memory/Table_Conversion_Spec.enso
6e639d3 
Co-authored-by: Radosław Waśko <[email protected]>
@GregoryTravis
ignored
306695d
@GregoryTravis
review
b9f2d72
@GregoryTravis
Merge branch 'wip/gmt/7958-from-objects-tests' into wip/gmt/7959-etr
7637c00
@GregoryTravis
remove test
ac1fbdd
@GregoryTravis
Merge branch 'wip/gmt/7958-from-objects-tests' into wip/gmt/7959-etr
058cdd7
@GregoryTravis
hack
afa7271
@GregoryTravis
improved fix
e8c87f7
@GregoryTravis
merge
757ff7c
@GregoryTravis
correct fix with test
8f88488
@GregoryTravis GregoryTravis linked an issue Oct 12, 2023 that may be closed by this pull request
Add Table.expand_to_rows to allow flattening vector and array values in table. #7959
Closed
@GregoryTravis GregoryTravis marked this pull request as ready for review October 12, 2023 16:45
@GregoryTravis GregoryTravis added CI: Clean build required CI runners will be cleaned before and after this PR is built. and removed CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Oct 12, 2023
jdunkerley
jdunkerley approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

radeusgd
radeusgd approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Ideally I'd suggest two changes before merging:

  1. Change the List conversion to avoid the unnecessarily costly O(N^2) traversal in favor of just re-using Vector logic.
  2. Add a test for rows disappearing due to [] being expanded - I did not see a test for that.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Oct 13, 2023
@GregoryTravis GregoryTravis added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Oct 13, 2023
@mergify mergify bot merged commit f18d132 into develop Oct 13, 2023
@mergify mergify bot deleted the wip/gmt/7959-etr branch October 13, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd radeusgd approved these changes

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Table.expand_to_rows to allow flattening vector and array values in table.
3 participants
@GregoryTravis @radeusgd @jdunkerley