-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all spans have document offsets #8039
Conversation
const parseCases = [ | ||
' foo bar\n', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that space was intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was, but I've changed handling of this case. It is now a syntax error to start a file with an indented line. This is now covered by the parser unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the libs change.
Pull Request Description
enso_parser_debug
.Important Notes
parse_all_enso_files.sh
is unchanged since before Parser TS bindings #7881 (modulo libs changes since then).0x
), it now emits aNumber
withNone
in the digits field rather than a 0-length digits token.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.