Using conversions in a few places

[jdunkerley]

Pull Request Description

• Shuffle a few froms into correct places:
  • Day_Of_Week.from removing Day_Of_Week_From module.
• Adding short cut for http and https in Data.read so it calls onto Data.fetch giving a single entry point.
• Moved URI extensions from Standard.Base.Data module into Standard.Base.Network.Extensions.
  • Added post extension for URI.
• Added contains_key to JS_Object.
• Restored into in JS_Object:
  • Follows old logic populating a constructor.
  • Will use conversion from JS_Object if present.
• Added automatic deserialization of Date, Time_Of_Day and Date_Time from JSON.
  • Uses conversion from JS_Object.
• Added conversion from Text to a HTTP_Method and type checking where HTTP_Method used in public APIs.
• Added support for Date, Time_Of_Day and Date_Time in Table.from_objects.
• Added expand_column to Table to expand JS_Object to values.
• Add type checking for Table in right arguments (allowing Columns to be used).
• Use type checking in Table.set to allow for conversion to a Column.
• Remove some unused imports.
• Fix for bug in S3 edge case.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[radeusgd]

Why is this an extension method and not just a regular method inside of Table.enso?

[jdunkerley]

Only because the from_objects would make the two files so intertwined felt more natural to have it next to here.

When we refactor from_objects, probably makes sense to fold in at that point.

[radeusgd]

Looks good generally, just a few small comments.

Tests look great, assuming we'll add more expand_column in the future, but I know that this is the plan 🙂