Cleanup code in IdExecutionInstrument #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
commented
Sep 14, 2023
| public interface IdExecutionService { | ||
| String INSTRUMENT_ID = "id-value-extractor"; | ||
|
|
||
| public interface Callbacks { |
There was a problem hiding this comment.
@hubertp , @4e6: one of the goals on the path towards running language server as guest Java/JS/Enso code
is to identify what kind of interface we need between the engine and the guest code to track execution. This is the interface. These four callback methods are enough to implement the execution tracking functionality of language server.
Next step. Use them from Enso, somehow.
JaroslavTulach
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
As part of investigation of #7683, let's make
IdExecutionEventNodesmaller by having a reference to factory and its fields.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,