Delay check of suspended arguments until they are about to be computed #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
commented
Sep 5, 2023
| try { | ||
| org.enso.interpreter.runtime.EnsoContext ctx = EnsoContext.get(this); | ||
| java.lang.Object newValue = invoke.execute(fn, null, State.create(ctx), new Object[0]); | ||
| set.execute(atom, newValue); | ||
| return newValue; | ||
| } catch (AbstractTruffleException ex) { | ||
| var rethrow = new SuspendedException(ex); | ||
| var rethrow = DataflowError.withTrace(ex, ex); | ||
| set.execute(atom, rethrow); |
There was a problem hiding this comment.
set.execute was failing with SuspendedException because the lazy field are runtime type checked and SuspendedException didn't have the right type ;-)
Changing into DataflowError as that is isAllFitValue.
JaroslavTulach
commented
Sep 5, 2023
| assertNotNull("member found", thirteen); | ||
| assertEquals(13, thirteen.asInt()); | ||
|
|
||
| var someHello = complex.execute("Hello", "World"); |
There was a problem hiding this comment.
Constructing Int.Complex is allowed, as the unwrap value is left as thunk. Only reading it later yields the error.
hubertp
approved these changes
Sep 5, 2023
JaroslavTulach
deleted the
wip/jtulach/SuspendedArgumentsTypeCheck_6883
branch
This was referenced Sep 6, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6883 by wrapping suspended arguments by
Functionthat adds a type check on the computed value.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,