Fix sbt task that creates GraalVM package #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking into #7698 discovered that the `buildGraalDistribution` task would fail to use the old (pre-23.0) GraalVM naming of artifacts. This has changed since #7176. The fix does not attempt to fix a problem of packaged GraalVM name in `runtime`. That, as the ticket mentiones it, is the role of rust build script that creates the correct bundle.
hubertp
added
the
CI: No changelog needed
JaroslavTulach
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
While looking into #7698 discovered that the
buildGraalDistributiontask would fail to use the old (pre-23.0) GraalVM naming of artifacts. This has changed since #7176 .Important Notes
The fix does not attempt to fix a problem of packaged GraalVM name in
runtime. That, as the ticket mentiones it, is the role of rust build script that creates the correct bundle.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.