-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification about the project rename action #7613
Notification about the project rename action #7613
Conversation
@farmaazon @MichaelMauderer how do I update the label with the project name? In this PR I implemented the update of the project properties, but it does not change the displayed text. enso/app/gui/src/model/project/synchronized.rs Lines 230 to 240 in 6b79ab8
|
We only read these properties once. Should be relatively easy change, I can do it in this branch later today if you want. |
@vitvakatu thank you, I'd appreciate your help. Or you can leave me some pointers on where to start, or what files need to be changed. Whatever is easier for you |
@4e6 done, but I can't test it locally because I can't build the engine from the source. Please try it and tell me if it does not work. Also, I removed some old code from times the IDE was renaming on its own. |
@vitvakatu thank you! The project name is updated now. I added a screencast to the description |
@@ -750,33 +774,6 @@ impl model::project::API for Project { | |||
.boxed_local() | |||
} | |||
|
|||
fn rename_project(&self, name: String) -> BoxFuture<FallibleResult> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean there is no way to rename the project while the project is open in the IDE? I tried clicking the project name on Friday and I was surprised there was no response. I guess that is intentional then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it is intentional. In the new design, you have to use the dashboard for renaming.
@Frizi or @MichaelMauderer please review, as I did some code changes myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed only rust files.
let mut properties = properties.borrow_mut(); | ||
properties.displayed_name = project_renamed.new_name.into(); | ||
properties.project_name.project = project_renamed.new_normalized_name.clone().into(); | ||
execution_contexts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is most likely fine currently, but it might be prudent to explicitly limit the mutable borrow doing another function call to avoid an accidental double borrow somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4e6 FYI, you can either add drop(properties)
after the last line that uses them or surround properties
-related code with curly braces to do that.
Pull Request Description
close #7604
After moving the rename action to the dashboard, IDE is unaware of the new project name. PR implements a new
refactoring/projectRenamed
notification that is sent from the server to clients and informs them about the changed project name.Important Notes
enso-7613.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.