Update GraalVM to 22.3.1 JDK17 #6750

Akirathan · 2023-05-18T09:29:16Z

Pull Request Description

Upgrade GraalVM to 22.3.2 based on JDK17.

How to Upgrade:
For SDKMan users:

sdk install java 22.3.1.r17-grl
sdk default java 22.3.1.r17-grl

For anybody else, just download the GraalVM distribution manually from https://github.com/graalvm/graalvm-ce-builds/releases/tag/vm-22.3.1 and set JAVA_HOME accordingly.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

Run benchmarks and ensure no regressions.
Try to install GraalPy and FastR and run interop tests
The documentation has been updated, if necessary.
All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:
- Unit tests have been written where possible.

Akirathan · 2023-05-19T07:44:04Z

I have tried:

Building native image of project-manager and launcher, and running some Enso code.
Yesterday's book club without any issues - AKKA appears to work on JDK17.
Dry-run benchmarks on CI work and normal benchmarks work on my machine.

Failing tests on the CI:

Some locale-related failure in test/Table_Tests: https://github.com/enso-org/enso/actions/runs/5015867538/jobs/8992003667?pr=6750#step:10:8284

GitHub
Update GraalVM to 22.3.2 JDK17 · enso-org/enso@226f9c7
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

4e6 · 2023-05-19T07:58:57Z

How is the benchmarks?

4e6

🎉

Akirathan · 2023-05-19T08:23:14Z

How is the benchmarks?

Do you think it is necessary to check benchmarks before integration? I guess that I should probably run them, at least from curiosity ..

JaroslavTulach · 2023-05-19T08:56:26Z

There are two groups of failing tests:

vectors of strings aren't equal - wow, what a fix - it is hard to spot a difference!
version check problem - maybe we could remove the text after Java-http-client/...

Some problems with locale on JDK17?

# Conflicts: # CHANGELOG.md

Akirathan · 2023-05-22T13:17:56Z

Apparently, there are no FastR, neither GraalPy releases for 22.3.2. I am reverting to 22.3.1 so that we can get interoperability with FastR and GraalPy.

https://github.com/oracle/fastr/releases

GitHub
Releases · oracle/fastr
A high-performance implementation of the R programming language, built on GraalVM. - oracle/fastr

This reverts commit 7ff2ab1

Akirathan · 2023-05-22T13:35:37Z

Reverted to GraalVM JDK17 22.3.1 in 84a9e65

Akirathan · 2023-05-22T13:36:43Z

Raised a question on GraalVM Slack polyglot channel "Why are FastR and GraalPy components not available on GraalVM JDK17 22.3.2" in https://graalvm.slack.com/archives/CP6RTC4LT/p1684762240737959

Slack

# Conflicts: # CHANGELOG.md

Akirathan · 2023-05-23T11:46:06Z

Package IDE (macos) job fails in signing the .dmg package with an output given here

The executable does not have the hardened runtime enabled.

Akirathan · 2023-05-23T11:49:19Z

Scheduled benchmarks in https://github.com/enso-org/enso/actions/runs/5056857474

GitHub
Benchmark Engine · enso-org/enso@5d07aa7
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

Akirathan · 2023-05-23T14:29:41Z

Scheduled benchmarks in https://github.com/enso-org/enso/actions/runs/5056857474

Benchmark results are fine. I will get the MacOS signature working and merge this PR.

GitHub
Benchmark Engine · enso-org/enso@5d07aa7
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

GraalVM hardened runtime.

somebody1234

just reviewing the single line of TS code. it's too long (131 chars > 100), but it might be easier if i run the formatter on it

(edit: formatter has been run.)

somebody1234 · 2023-05-23T15:05:51Z

weird, prettier is fine with that line

edit: oh, just forgot to pull

Akirathan · 2023-05-23T15:13:35Z

weird, prettier is fine with that line

edit: oh, just forgot to pull

Thanks!

Akirathan · 2023-05-23T19:07:21Z

test/Table_Tests/src/In_Memory/Column_Format_Spec.enso

@@ -307,7 +307,7 @@ spec_with_numeric_type name numeric_type =

        Test.specify "Column with locale" <|
            input = Column.from_vector "values" ["100000000", "2222", "3"] . parse numeric_type
-            expected = Column.from_vector "values" ["100 000 000,00", "2 222,00", "3,00"]
+            expected = Column.from_vector "values" ["100 000 000,00", "2 222,00", "3,00"]


This is a change of a Unicode symbol for a whitespace.

The old Unicode character was U+A0 and the new one is U+202F

Akirathan · 2023-05-23T19:08:50Z

...src/main/scala/org/enso/runtimeversionmanager/components/GraalVMComponentConfiguration.scala

+    val optRComponent =
+      if (os.hasRSupport) Seq(GraalVMComponent.R) else Seq()


This is a separate fix that I noticed recently from @xvcgreg's logs from another issue. Apparently, we try to install FastR on Windows, but that is not possible - it is not supported on Windows. Same case as with GraalPy, but FastR will, most probably, never be supported on Windows.

jdunkerley

LGTM

…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...

- Previous GraalVM update: #6750 Removed warnings: - Remove deprecated `ConditionProfile.createCountingProfile()`. - Add `@Shared` to some `@Cached` parameters (Truffle now emits warnings about potential `@Share` usage). - Specialization method names should not start with execute - Add limit attribute to some specialization methods - Add `@NeverDefault` for some cached initializer expressions - Add `@Idempotent` or `@NonIdempotent` where appropriate BigInteger and potential Node inlining are tracked in follow-up issues. # Important Notes For `SDKMan` users: ``` sdk install java 17.0.7-graalce sdk use java 17.0.7-graalce ``` For other users - download link can be found at https://github.com/graalvm/graalvm-ce-builds/releases/tag/jdk-17.0.7 Release notes: https://www.graalvm.org/release-notes/JDK_17/ R component was dropped from the release 23.0.0, only `python` is available to install via `gu install python`.

Update graalvm version constants at various places

f8d0b79

Akirathan linked an issue May 18, 2023 that may be closed by this pull request

Upgrade to GraalVM based on JDK17 #6274

Closed

Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label May 18, 2023

Akirathan added 2 commits May 18, 2023 18:05

Update CHANGELOG

226f9c7

FIx GraalVM component configuration

7ff2ab1

Akirathan self-assigned this May 19, 2023

Akirathan marked this pull request as ready for review May 19, 2023 07:46

Akirathan requested review from 4e6, JaroslavTulach, radeusgd, hubertp and mwu-tow as code owners May 19, 2023 07:46

4e6 approved these changes May 19, 2023

View reviewed changes

Akirathan added 3 commits May 19, 2023 16:17

Fix java versions in Http_Spec.enso test

485685b

Fix Unicode symbol in Column_Format_Spec

d052fea

Some problems with locale on JDK17?

Fix os requirements for FastR

c1ea867

Akirathan requested review from jdunkerley and GregoryTravis as code owners May 19, 2023 15:10

Akirathan added 2 commits May 22, 2023 14:56

FIx another Unicode symbol in Column_Format_Spec

bae4271

Merge branch 'develop' into wip/akirathan/upgrade-graal-jdk17-6274

9898a51

# Conflicts: # CHANGELOG.md

Akirathan added 3 commits May 22, 2023 15:26

Revert "FIx GraalVM component configuration"

fdb5ec0

This reverts commit 7ff2ab1

Revert to GraalVM JDK17 22.3.1

84a9e65

Re-enable tests in Column_Format_Spec

a2b8deb

Akirathan changed the title ~~Update GraalVM to 22.3.2 JDK17~~ Update GraalVM to 22.3.1 JDK17 May 22, 2023

Akirathan added 4 commits May 22, 2023 15:40

fmt

533e29e

Merge branch 'develop' into wip/akirathan/upgrade-graal-jdk17-6274

590e452

# Conflicts: # CHANGELOG.md

Fix GraalVMComponentConfigurationSpec test

04ffa91

Fix tests, fmt

5d07aa7

hubertp approved these changes May 23, 2023

View reviewed changes

JaroslavTulach approved these changes May 23, 2023

View reviewed changes

Fix electron builder notarization on MacOS.

60cdc55

GraalVM hardened runtime.

Akirathan requested review from PabloBuchu, indiv0 and somebody1234 as code owners May 23, 2023 15:02

somebody1234 approved these changes May 23, 2023

View reviewed changes

Run prettier

8f52d6e

Akirathan commented May 23, 2023

View reviewed changes

jdunkerley approved these changes May 24, 2023

View reviewed changes

mwu-tow approved these changes May 24, 2023

View reviewed changes

Akirathan merged commit bd70ed6 into develop May 24, 2023

Akirathan deleted the wip/akirathan/upgrade-graal-jdk17-6274 branch May 24, 2023 08:39

Akirathan mentioned this pull request May 24, 2023

Various test improvements to increase coverage and speed things up #6820

Merged

2 tasks

Akirathan mentioned this pull request Jul 4, 2023

Update GraalVM to 17.0.7 (23.0.0 JDK17) #7176

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GraalVM to 22.3.1 JDK17 #6750

Update GraalVM to 22.3.1 JDK17 #6750

Akirathan commented May 18, 2023 •

edited

Loading

Akirathan commented May 19, 2023 •

edited by unfurl-links bot

Loading

4e6 commented May 19, 2023

4e6 left a comment

Akirathan commented May 19, 2023

JaroslavTulach commented May 19, 2023 •

edited

Loading

Akirathan commented May 22, 2023 •

edited by unfurl-links bot

Loading

Akirathan commented May 22, 2023

Akirathan commented May 22, 2023 •

edited by unfurl-links bot

Loading

Akirathan commented May 23, 2023

Akirathan commented May 23, 2023 •

edited by unfurl-links bot

Loading

Akirathan commented May 23, 2023 •

edited by unfurl-links bot

Loading

somebody1234 left a comment •

edited

Loading

somebody1234 commented May 23, 2023 •

edited

Loading

Akirathan commented May 23, 2023

Akirathan May 23, 2023

Akirathan May 24, 2023

Akirathan May 23, 2023

jdunkerley left a comment

		val optRComponent =
		if (os.hasRSupport) Seq(GraalVMComponent.R) else Seq()

Update GraalVM to 22.3.1 JDK17 #6750

Update GraalVM to 22.3.1 JDK17 #6750

Conversation

Akirathan commented May 18, 2023 • edited Loading

Pull Request Description

Important Notes

Checklist

Akirathan commented May 19, 2023 • edited by unfurl-links bot Loading

4e6 commented May 19, 2023

4e6 left a comment

Choose a reason for hiding this comment

Akirathan commented May 19, 2023

JaroslavTulach commented May 19, 2023 • edited Loading

Akirathan commented May 22, 2023 • edited by unfurl-links bot Loading

Akirathan commented May 22, 2023

Akirathan commented May 22, 2023 • edited by unfurl-links bot Loading

Akirathan commented May 23, 2023

Akirathan commented May 23, 2023 • edited by unfurl-links bot Loading

Akirathan commented May 23, 2023 • edited by unfurl-links bot Loading

somebody1234 left a comment • edited Loading

Choose a reason for hiding this comment

somebody1234 commented May 23, 2023 • edited Loading

Akirathan commented May 23, 2023

Akirathan May 23, 2023

Choose a reason for hiding this comment

Akirathan May 24, 2023

Choose a reason for hiding this comment

Akirathan May 23, 2023

Choose a reason for hiding this comment

jdunkerley left a comment

Choose a reason for hiding this comment

Akirathan commented May 18, 2023 •

edited

Loading

Akirathan commented May 19, 2023 •

edited by unfurl-links bot

Loading

JaroslavTulach commented May 19, 2023 •

edited

Loading

Akirathan commented May 22, 2023 •

edited by unfurl-links bot

Loading

Akirathan commented May 22, 2023 •

edited by unfurl-links bot

Loading

Akirathan commented May 23, 2023 •

edited by unfurl-links bot

Loading

Akirathan commented May 23, 2023 •

edited by unfurl-links bot

Loading

somebody1234 left a comment •

edited

Loading

somebody1234 commented May 23, 2023 •

edited

Loading