Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard issues #6502

Merged
merged 8 commits into from
May 5, 2023
Merged

Fix dashboard issues #6502

merged 8 commits into from
May 5, 2023

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented May 2, 2023 •
edited
Loading

Pull Request Description

Screenshots/screencasts

404:
image
405:

screen-recorder-tue-may-02-2023-20-50-56.mp4

406:

screen-recorder-tue-may-02-2023-20-59-43.mp4

408:
Local backend:
image
Remote backend:
image
410:
note the lack of webgl errors. errors do appear at the end, but that is caused by drop() from switching or stopping the currently active project. i don't think it will cause issues during usage as it only happens when the IDE is closing.
https://user-images.githubusercontent.com/4046547/235669442-f76636be-2685-4a6d-b996-df75387df53d.mp4

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234
Copy link
Contributor Author

This PR is ready implementation-wise, but it is blocking on another PR.

@somebody1234
Copy link
Contributor Author

typecheck: passing
eslint: passing
prettier: passing

@somebody1234 somebody1234 requested a review from PabloBuchu May 2, 2023 11:05
@somebody1234
Copy link
Contributor Author

not sure why the screencasts aren't embedding properly :(

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 2, 2023
@somebody1234 somebody1234 mentioned this pull request May 2, 2023
Merged
5 tasks
Base automatically changed from wip/sb/cloud-desktop-mode-switcher to develop May 2, 2023 17:48
@somebody1234 somebody1234 force-pushed the wip/sb/fix-dashboard branch from 905d517 to ba3d9f9 Compare May 2, 2023 17:52
@somebody1234
Copy link
Contributor Author

force-pushed because github doesn't squash commits that were merged in for some reason

@somebody1234 somebody1234 marked this pull request as ready for review May 3, 2023 00:24
@somebody1234 somebody1234 requested a review from indiv0 as a code owner May 3, 2023 00:24
@PabloBuchu
Copy link
Contributor

@somebody1234 Colorado Covid template is using wrong name when creating a project. Locally and remotly it should be colorado_covid now it is coloradocovid which is unrecognizable by local project manager

@somebody1234 somebody1234 mentioned this pull request May 5, 2023
Closed
5 tasks
@somebody1234
Copy link
Contributor Author

whoops, the logic was indeed wrong. i've kept the capitalization though, which is copied from the rust names i think. i've tested creating projects and they work and create the correct project locally, but @PabloBuchu you might want to check as well just to be extra sure it's really fixed

@PabloBuchu
Copy link
Contributor

QA 🟢

@PabloBuchu PabloBuchu merged commit 30f27be into develop May 5, 2023
@PabloBuchu PabloBuchu deleted the wip/sb/fix-dashboard branch May 5, 2023 10:50
Procrat added a commit that referenced this pull request May 10, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
8c07d54 
* develop: (28 commits)
  Add tests for Date.until, Date.next and Date.previous. (#6606)
  Improve `Non_Unique_Primary_Key` error, split file format detection into read/write, improve SQLite format detection (#6604)
  tokenize_to_columns or parse_to_columns results in a single column we shouldn't add the  1 (#6607)
  Fix node editing race condition (#6594)
  Add format to the in-memory Column (#6538)
  Fix dashboard issues (part 2) (#6511)
  Fix visualisation type selector artifacts rendered after node preview visualisation was closed. (#6575)
  Revert typescript CI Lint changes (#6602)
  Fix the Engine version check in GUI (#6570)
  Show error pop-up when failing to rename a project (#6366)
  Small changes from Book Club issues (#6533)
  "at_least_one" flag for tokenize_to_rows (#6539)
  Benchmark Engine job runs only engine, not Enso benchmarks (#6534)
  Catch 5813 and avoid crash (#6585)
  Fix opening links in desktop IDE (#6507)
  Identify SyntaxError exception and avoid printing a stack trace (#6574)
  Fix dashboard issues (#6502)
  Let ChangesetBuilder.invalidated search even container elements (#6548)
  Fix #5075: stop panning on full-screen visualisation (#6530)
  Only `Join_Kind.Inner` removes the common-named columns (#6564)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somebody1234 @PabloBuchu