Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run typecheck and eslint on ./run lint #6314

Merged
merged 7 commits into from
May 4, 2023
Merged

Run typecheck and eslint on ./run lint #6314

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d97369
Run typecheck and eslint on `./run lint`
somebody1234 Apr 17, 2023
c6b4d57
Make TypeScript lint return error on type errors
somebody1234 Apr 19, 2023
b70b1f1
Merge branch 'develop' into wip/sb/run-lint-tsc-eslint
somebody1234 Apr 24, 2023
2fc9690
Remove newlines
somebody1234 Apr 24, 2023
4385510
Run `npm install` to fix `tsc` invocation
somebody1234 Apr 28, 2023
d46d736
Merge branch 'develop' into wip/sb/run-lint-tsc-eslint
somebody1234 Apr 28, 2023
536f07c
Fix lint errors
somebody1234 Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions build/cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ use ide_ci::programs::git;
use ide_ci::programs::git::clean;
use ide_ci::programs::rustc;
use ide_ci::programs::Cargo;
use ide_ci::programs::Npm;
use ide_ci::programs::Npx;
use std::time::Duration;
use tempfile::tempdir;
use tokio::process::Child;
Expand Down Expand Up @@ -835,6 +837,12 @@ pub async fn main_internal(config: Option<enso_build::config::Config>) -> Result
.await?;

prettier::check(&ctx.repo_root).await?;

let js_modules_root = ctx.repo_root.join("app/ide-desktop");

Npm.cmd()?.current_dir(&js_modules_root).args(["run", "typecheck"]).run_ok().await?;

Npx.cmd()?.current_dir(&js_modules_root).args(["eslint", "."]).run_ok().await?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we creating these newlines here? I don't think they are needed - they just make the code longer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

}
Target::Fmt => {
let prettier = prettier::write(&ctx.repo_root);
Expand Down