Implementation of EnsoGL predefined Rectangle shape. #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdanilo
added
the
CI: No changelog needed
wdanilo
requested review from
MichaelMauderer,
farmaazon and
kazcw
as code owners
farmaazon
approved these changes
Mar 22, 2023
Comment on lines
+40
to
+43
| let canvas_clip_height_diff = &canvas_height * (clip.y() * 2.0); | ||
| let canvas_clip_width_diff = &canvas_width * (clip.x() * 2.0); | ||
| let canvas_height = canvas_height + &canvas_clip_height_diff; | ||
| let canvas_width = canvas_width + &canvas_clip_width_diff; |
There was a problem hiding this comment.
not clear variable names
| let canvas_width = canvas_width + &canvas_clip_width_diff; | ||
|
|
||
| // === Body === | ||
| let inset2 = (&inset * 2.0).px(); |
There was a problem hiding this comment.
Maybe padding is better than inset?
There was a problem hiding this comment.
I'll leave inset here, as we discussed, as this is term used in CSS and Swift. Padding is used in display objects and it will get confusing if we will use it here as well, especially, as this shape implements display object.
kazcw
approved these changes
Mar 22, 2023
Procrat
added a commit
that referenced
this pull request
Mar 27, 2023
* develop: Layout fixes (#6066) Use new Enso Hash Codes and Comparable (#6060) Search suggestions by static attribute (#6036) Use .node-version for pinning Node.js version (#6057) Fix code generation for suggestion preview (#6054) Implementation of EnsoGL predefined Rectangle shape. (#6033) Tidy up the public module level statics (#6032) Cursor aware Component Browser (#5770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR implements a "super-shape",
Rectangle. This shape has been specifically designed to be utilized across various sections of the GUI. Its numerous parameters enable a highly adaptable approach to drawing a diverse range of shapes, such as circles, rings, or ring segments. The advantage of having a singular shape for these cases is that a single draw call can be used to render multiple GUI elements, which ultimately enhances performance.Screen.Recording.2023-03-22.at.07.26.31.mov
Important Notes
unify_exclusive, allowing blending their colors based on the foreground shape's SDF value. This means that even if these shapes overlap and the foreground is semi-transparent, it will blend with the background only in the anti-aliased areas. This allows us to render both rectangle and its border without artifacts between them, no matter the scene zoom level or camera transformation.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.