Implement Regular Expression replace and update Text.replace to the new API

[GregoryTravis]

Pull Request Description

Re-implement replace on top of Truffle regex.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[wdanilo]

PR has not descriptive title and the checkboxes are not checked. Please be sure to test the PR before merging this PR (this should result in checking the checkboxes).

[jdunkerley]

PR has not descriptive title and the checkboxes are not checked. Please be sure to test the PR before merging this PR (this should result in checking the checkboxes).

The PR has been fully tested and the description now updated. Please re-review so we can get merged.

[GregoryTravis]

Already done.

…

On Mon, Mar 27, 2023 at 8:04 AM Radosław Waśko ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/Tests/src/Data/Text_Spec.enso <#5959 (comment)>: > - tr_insensitive = Text_Matcher.Case_Insensitive (Locale.new "tr") - "Iiİı" . replace "i" "-" matcher=tr_insensitive . should_equal "I--ı" - "Iiİı" . replace "I" "-" matcher=tr_insensitive . should_equal "-iİ-" - "Iiİı" . replace "İ" "-" matcher=tr_insensitive . should_equal "I--ı" - "Iiİı" . replace "ı" "-" matcher=tr_insensitive . should_equal "-iİ-" + Test.specify "should correctly handle Unicode" <| + 'ß'.replace 'S' 'A' case_sensitivity=Case_Sensitivity.Insensitive . should_equal 'AA' + 'ß'.replace 'ß' 'A' case_sensitivity=Case_Sensitivity.Insensitive . should_equal 'A' + 'affib'.replace 'ffi' 'X' case_sensitivity=Case_Sensitivity.Insensitive . should_equal 'aXb' Can we add 'affib'.replace 'i' 'X' case_sensitivity=Case_Sensitivity.Insensitive . should_equal 'aXb' here? — Reply to this email directly, view it on GitHub <#5959 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF2GQOXYE72HKEV27YYBAE3W6F65VANCNFSM6AAAAAAV4JXN2Y> . You are receiving this because you authored the thread.Message ID: ***@***.***>